DataViews: Use in patterns page #57333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
Needs Design
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal,
jameskoster,
SaxonF,
ramonjd and
aaronrobertshaw
|
Size Change: +1.06 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6a58942. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7298932102
|
1 task
ntsekouras
force-pushed
the
try/dataviews-patterns-page
branch
from
6a58942
to
d26df02
Compare
|
This is surprisingly good :). The link in "synced patterns" is a bit weird, kind of does nothing. 
I was also expecting the "click on preview" to go to the pattern page. |
youknowriad
reviewed
Jan 1, 2024
packages/edit-site/src/components/page-patterns/dataviews-pattern-actions.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Jan 1, 2024
| totalPages: Math.ceil( totalItems / view.perPage ), | ||
| }, | ||
| }; | ||
| }, [ patterns, view, fields ] ); |
There was a problem hiding this comment.
Feels like the data views package could expose helpers for local filtering and sorting as I believe the logic here is probably very similar to the templates page as well and any data view where the filtering and sorting is done locally.
youknowriad
reviewed
Jan 1, 2024
| }, [ patterns, view, fields ] ); | ||
|
|
||
| const actions = useMemo( () => [ renameAction, exportJSONaction ], [] ); | ||
| const onChangeView = useCallback( |
There was a problem hiding this comment.
At some point we should consider whether we could bundle this logic as well as it repeats itself across data views usage. We may be able to do so by adding the defaultConfigPerViewType as a prop.
Also, it seems we're adding more and more "config" props, maybe at some point we could have a "settings" prop with a lot of these instead of keeping them top level.
There was a problem hiding this comment.
Yeah. I'm thinking of landing an initial PR without all the actions too(to reduce the size of this PR) and have some follow ups to simplify things a bit.
oandregal
reviewed
Jan 2, 2024
packages/edit-site/src/components/page-patterns/dataviews-patterns.js
Outdated
Show resolved
Hide resolved
ntsekouras
force-pushed
the
try/dataviews-patterns-page
branch
from
68dba2c
to
64632a8
Compare
Fixed that.
This is an issue we need to handle in general yes, but I'm not sure it's for this PR. I'm thinking that we could test and land this PR and continue with follow ups due to the big size of the PR. For example to add the What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55083
This PR is the starting point of using DataViews in patterns page. There is a lots of stuff going on with patterns and this might be also an opportunity to try to simplify the code, but I'm planning to explore this iteratively.
This is a WIP so the description/screenshots and code will change.
Testing Instructions
Tasks
Screenshots or screencast