Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Ensure font is scaled on iOS when accessibility settings are changed #57339

Merged
merged 5 commits into from Dec 22, 2023
Merged

[RNMobile] Ensure font is scaled on iOS when accessibility settings are changed #57339

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89dbd65
Ensure font is scaled as expected
SiobhyB Dec 22, 2023
60e287f
Revert accidental new line
SiobhyB Dec 22, 2023
061d327
Refactor code for readability/conciseness
SiobhyB Dec 22, 2023
cbb1078
Remove duplicate and incorrect 'let' declaration
SiobhyB Dec 22, 2023
d98f0b7
Refactor newFontSize init for clarity/conciseness
SiobhyB Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Expand Up @@ -651,12 +651,9 @@ class RCTAztecView: Aztec.TextView {
private func applyFontConstraints(to baseFont: UIFont) -> UIFont {
let oldDescriptor = baseFont.fontDescriptor
let newFontSize: CGFloat
let fontMetrics = UIFontMetrics(forTextStyle: .body)

if let fontSize = fontSize {
newFontSize = fontSize
} else {
newFontSize = baseFont.pointSize
}
newFontSize = fontMetrics.scaledValue(for: fontSize ?? baseFont.pointSize)
twstokes marked this conversation as resolved.
Show resolved Hide resolved

var newTraits = oldDescriptor.symbolicTraits

Expand Down