[Dataviews] Table layout: Ensure focus is not lost on interaction #57340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tables are sorted or paginated, focus can be lost if the new data takes time to come back. This patch keeps the table header in place, whether data exists or not, and persists stale data until new data is returned, ensuring focus is not lost. Additionally, when columns are hidden from the column header menu, focus is also lost as the header menu no longer exists. This patch adds an `onHide` callback to each header menu, which when called will put the focus on a fallback header menu.
andrewhayward
added
[Type] Enhancement
andrewhayward
requested review from
oandregal,
jameskoster,
ntsekouras and
a team
|
Very nice, do you think it's worth rebasing to check this against the latest work around dropdown menus? |
Yes. I thought I was up to date when I cut the branch, but evidently not! Rebased now, things still seem to work without issue. Interaction.with.latest.menu.implementation.mov |
|
Size Change: +1.31 kB (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 38fc7e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7301259607
|
mirka
reviewed
Dec 25, 2023
There was a problem hiding this comment.
Great improvement!
The focus behavior in particular seems like a great thing to have automated tests for. There doesn't seem to be any tests for this component yet so I'm not sure if we're waiting for things to stabilize more, but in the long run it'd be great to have test coverage since this will be a very complicated component.
oandregal
reviewed
Dec 26, 2023
oandregal
reviewed
Dec 26, 2023
oandregal
reviewed
Dec 26, 2023
oandregal
reviewed
Dec 26, 2023
oandregal
reviewed
Dec 26, 2023
oandregal
added
[Type] Experimental
Just a wrangling update: I've changed the The |
oandregal
reviewed
Jan 4, 2024
oandregal
reviewed
Jan 4, 2024
oandregal
reviewed
Jan 4, 2024
oandregal
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57341.
What?
This PR does
threetwo relatively small things:It persists stale data, to maintain visual consistency, which is rendered and marked asinertwhile fresh data is being fetched (sorting, pagination, etc).Why?
When tables are sorted, filtered, or paginated, new data can be fetched. If this takes time to come back, the header is currently replaced with a "no results" message, until the fetch is complete. With the table header remaining in place, focus within header menus is persisted.
Separately, when columns are hidden from the column header menu, the menu is necessarily removed from the DOM, which leaves focus at the whim of the user agent. We need to be intentional about focus movement in this case.
How?
hasDatacheck, so that it is always rendered, regardless of whether data exists.A reference is maintained of previously rendered data, which is used when no current data is available.Testing Instructions
Testing Instructions for Keyboard
The same interactions should be validated using the keyboard – focus should not be lost at any point.
Screenshots or screencast
The table layout with no data – the header row is persisted.
Column header removal, showing focus being explicitly moved to a different column.
refocus.on.column.removal.mov