RadioControl: Fully encapsulate styles #57347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
Size Change: +112 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5b7f662. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7301615837
|
ciampo
approved these changes
Dec 22, 2023
Eventually, yes! Ideally I'd like to do a handful of components at once to make whatever approach we take is sustainable/scalable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50428
Fixes #26293
What?
Fully encapsulates the styles required for RadioControl so that it looks like it does in a WordPress context.
Why?
RadioControl had several stylistic issues, including not reflecting the components theme color (#50428), and having weird focus styles in Firefox (#26293). In fact, RadioControl in isolation (e.g. in Storybook) looked quite different from when rendered inside the Gutenberg editor, which was actually the correct design.
This was due to a lot of the necessary styles being provided through the
forms.cssstylesheet that is loaded globally in WordPress contexts.How?
Adds the necessary styles so it looks correct regardless of whether
forms.cssis loaded.Testing Instructions
See the RadioControl story in Storybook.
It should look the same as when
forms.cssis loaded.Component theme colors should apply correctly.
CleanShot.2023-12-23.at.00.42.58-converted.mp4
Screenshots or screencast