Snackbar: Fix icon positioning #57377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
mirka
commented
Dec 26, 2023
| 🌮 | ||
| </span> | ||
| ), | ||
| icon: <Icon style={ { fill: 'currentcolor' } } icon={ wordpress } />, |
There was a problem hiding this comment.
Not great that this requires a style, but we can't really add it in the component CSS due to back-compat.
Hopefully things will be nicer once we have #40102.
|
Size Change: +19 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Jan 2, 2024
| top: 24px; | ||
| left: 28px; | ||
| left: $grid-unit-10 * -1; | ||
| top: -3px; |
There was a problem hiding this comment.
Is the icon supposed to be top aligned when the snackbar text breaks on 2+ lines?
More in general, we should probably switch to a more generic approach to vertically centering the icon that doesn't rely on an exact px value, since it would make the alignment more resilient to things like font changes, etc.
There was a problem hiding this comment.
Is the icon supposed to be top aligned when the snackbar text breaks on 2+ lines?
Correct. It matches the alignment of the actions and dismiss button as well.
More in general, we should probably switch to a more generic approach to vertically centering the icon that doesn't rely on an exact px value, since it would make the alignment more resilient to things like font changes, etc.
Added a few tweaks to avoid this in 312752d 👍
| @@ -29,13 +29,14 @@ | |||
| } | |||
|
|
|||
| .components-snackbar__content-with-icon { | |||
| margin-left: $grid-unit-30; | |||
| position: relative; | |||
| padding-left: $grid-unit-30; | |||
There was a problem hiding this comment.
I was about to suggest using logical properties (inline-start instead of left), but I guess that it doesn't matter much in Sass files, since RTL styles should be automatically generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56126
What?
Fixes the icon positioning in the
Snackbarcomponent, and updates the Storybook story to reflect how it is intended to be used per the WordPress design system (24px icon with a solid color fill).As seen on Figma:
Testing Instructions
See the "Snackbar - With Icon" story in Storybook. The icon should be positioned properly in different situations, e.g. when the content is long and wraps, when there is an
explicitDismissbutton, or when there are actions.Screenshots or screencast
In SnackbarList