Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuotonePicker: Fix top margin when no duotone options #57489

Merged
merged 3 commits into from Jan 3, 2024
Merged

DuotonePicker: Fix top margin when no duotone options #57489

merged 3 commits into from Jan 3, 2024

Conversation

mirka
Copy link
Member

@mirka mirka commented Jan 2, 2024

Part of #39358

What?

Removes an unintended top margin on the DuotonePicker component when duotonePalette={ [] } and unsetable={ false }.

Why?

Components should not include outer margins.

Testing Instructions

In Storybook, see the DuotonePicker story. Set the duotonePalette prop to an empty array, and unsetable to false.

Screenshots or screencast

Before After
DuotonePicker with top margin DuotonePicker with no top margin

@mirka mirka added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Jan 2, 2024
@mirka mirka self-assigned this Jan 2, 2024
@mirka mirka requested a review from ajitbohra as a code owner January 2, 2024 15:24
@mirka mirka mentioned this pull request Jan 2, 2024
Open
20 tasks
@mirka mirka requested a review from a team January 2, 2024 15:27
ciampo
ciampo approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ciampo ciampo enabled auto-merge (squash) January 3, 2024 21:46
@ciampo ciampo merged commit 5f6467d into trunk Jan 3, 2024
56 checks passed
@ciampo ciampo deleted the fix/duotone-picker-margin branch January 3, 2024 22:13
@github-actions github-actions bot added this to the Gutenberg 17.5 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@mirka mirka

Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mirka @ciampo