Site editor: reinstate iframe CSS for editor canvas container #57503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e editor iframe, but the editor canvas container, e.g., style book
ramonjd
added
[Type] Bug
aaronrobertshaw
approved these changes
Jan 3, 2024
|
Size Change: +22 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I made a bug!
In:
This PR reinstates site editor iframe styles because they influence not only the editor iframe, but the editor canvas container, e.g., style book
Why?
#57330 accidentally removed the height and width from any iframe in the site editor, moving the styles to the block editor component.
Little did I know, the rule was also targeting other iframes. So we see this:
How?
Reinstating the iframe rules.
Any optimizations can come later. Let's fix it first.
Testing Instructions