New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataview: Change the stacking order of table header #57565
Conversation
Size Change: +10 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change sounds fine to me. Though I'd appreciate it if others with more stacking expertise would chime in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me 👍
Thanks for the review, @oandregal, @jameskoster! |
What?
This PR changes the stacking order by applying
z-index:1
to the Dataview table header cell. This prevents translucent buttons from overlapping header cells.Why?
When the button is disabled, it has
opacity:0.3
style. Strangely, only the translucent button overlaps the header cell. This may have something to do with the element being placed in a new stacking context when opacity is applied (This article explains its specifications in detail).How?
Added
z-index: 1
to header cell.Testing Instructions