[Mobile] Update iOS runner to macos-13 and Xcode 15.1 #57708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
fluiddot
reviewed
Jan 10, 2024
Comment on lines
-9
to
+11
| "deviceName": "iPhone 14 Simulator", | ||
| "deviceTabletName": "iPad (10th generation) Simulator" | ||
| }, | ||
| "buildkite": { | ||
| "platformVersion": "16.4" | ||
| "deviceName": "iPhone 15 Simulator", | ||
| "deviceTabletName": "iPad (10th generation) Simulator", | ||
| "platformVersion": "17.0" |
There was a problem hiding this comment.
For reference, these parameters are no longer used in Gutenberg Mobile after this change.
There was a problem hiding this comment.
Ideally, we should use the same parameters in both local and SauceLabs runs. However, I'm not sure if this will be always the case, as it will depend on the devices supported in SauceLabs. That said, we might consider reverting this change to be able to run E2E tests locally and in CI.
There was a problem hiding this comment.
Yeah, I've removed the buildkite config and moved the platformVersion to the SauceLabs one since they don't support 17.2 simulators yet. Ideally, we will have the same version once we run the tests in our CI environment.
we might consider reverting this change to be able to run E2E tests locally and in CI.
Yup something to consider for sure!
geriux
force-pushed
the
feature/ios-update-simulator
branch
3 times, most recently
from
e074d2c
to
44e1888
Compare
geriux
force-pushed
the
feature/ios-update-simulator
branch
from
44e1888
to
e54ead4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast