Add description to the save panel header when nothing is checked #57716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Copy
|
Size Change: +166 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in baeea76. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7474526220
|
ramonjd
reviewed
Jan 10, 2024
| 'The following changes have been made to your site, templates, and content.' | ||
| ) | ||
| : __( | ||
| 'No changes will be made to your site, templates, and content. Select the items you want to save.' |
There was a problem hiding this comment.
I think this is a good change in general.
Would "Select the items you wish to save." be enough or do we need a qualifying statement?
There was a problem hiding this comment.
+1, really good idea having some descriptive text, but I like the idea of shortening it a little if we can 👍
There was a problem hiding this comment.
Would
"Select the items you wish to save."be enough or do we need a qualifying statement?
Certainly, I think this is sufficient. Updated by 4b1036b👍
ramonjd
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52689
What?
This PR adds a message to the save panel header when nothing is checked.
Why?
When no entity is checked, the save button is disabled. Some users may find it difficult to understand why they are disabled without an explanation.
How?
Added description. Props to @benwormald who suggested this message in this comment.
If you have a more appropriate message, I welcome your suggestions.
Testing Instructions