Editor styles: cache transform #57810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +45 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
memo-editor-styles-transform
branch
from
3873f27
to
28f2fc0
Compare
|
Flaky tests detected in 28f2fc0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7514490632
|
ellatrix
changed the title
youknowriad
reviewed
Jan 16, 2024
| @@ -5,6 +5,52 @@ import postcss, { CssSyntaxError } from 'postcss'; | |||
| import wrap from 'postcss-prefixwrap'; | |||
| import rebaseUrl from 'postcss-urlrebase'; | |||
|
|
|||
| const transformStylesCache = new WeakMap(); | |||
There was a problem hiding this comment.
WeakMap is such a magic tool :P
youknowriad
reviewed
Jan 16, 2024
| @@ -18,45 +64,14 @@ import rebaseUrl from 'postcss-urlrebase'; | |||
| * @return {Array} converted rules. | |||
| */ | |||
| const transformStyles = ( styles, wrapperSelector = '' ) => { | |||
There was a problem hiding this comment.
As mentioned in person, if we're using an iframe, transforming styles might not be necessary anymore assuming we also pass the "url" to the stylesheet in addition to its content. We could just use the URL to load the stylesheets within the iframe.
There was a problem hiding this comment.
Right, I'll try this next. This PR is still useful for an editor without iframe though (when there's a registered block that is not v3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Editor styles settings remain constant for all previews, so we should cache the transforms so the work is not repeated for each preview.
Why?
1st run: -5% (load patterns)
2nd run -5.6%
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast