Data: allow binding registry selector to multiple registries #57943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +91 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/registry-selectors-switching-registries
branch
from
c9f9c58
to
2a77bb2
Compare
ellatrix
force-pushed
the
try/registry-selectors-switching-registries
branch
from
2a77bb2
to
73cccd9
Compare
This was referenced Jan 19, 2024
jsnajdr
approved these changes
Jan 19, 2024
packages/data/src/factory.js
Outdated
| } | ||
| return selector( ...args ); | ||
| return selectorsByRegistry.get( wrappedSelector.registry )( ...args ); |
There was a problem hiding this comment.
Let's write the code in such a way that there is ony one .get map lookup, not the two .has and .get. This will be called all the time, so a micro-opt is justified.
|
There's still the very fragile case where registry selectors are called without binding, from normal selectors: const getFoo = createRegistrySelector( ... );
const getBar = ( state ) => { getFoo( state ) };Both before and this PR there will be erratic behavior. But that's solvable only with |
|
Yeah, there's definitely a bunch of things that still remain to be fixed. Another thing is that |
|
Flaky tests detected in 5a1c598. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7584672596
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Currently it's not possible to bind a "registry selector" (created through
createRegistrySelector) to multiple registries. This is because the selector is bound (registry property set) when a registry initialises, so on the next initialisation thisregistryproperty is overridden.The easiest solution here is to "switch" registries before calling the selector.
Additionally a cache should be kept for each registry, which shouldn't invalidate when initialising or switching to other registries.
Why?
It currently prevents me from adding registry selectors to the block editor store, because it's possible to create multiple instances of these (separate editor instances in previews for example).
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast