Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 馃憢 emoji from the Block Editor Handbook #58023

Merged
merged 1 commit into from Jan 19, 2024

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Jan 19, 2024

While emojis are fun, I do not think this specific emoji is needed, and it's also negatively impacting the Open Graph Meta for the page, see WordPress/wporg-developer#478.

Before After
image image

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Jan 19, 2024
@ndiego ndiego self-assigned this Jan 19, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the emoji gives it a nice approachable charm and am sad to see it go. But can see your reasons and it makes sense to me 馃憤

@fabiankaegy fabiankaegy enabled auto-merge (squash) January 19, 2024 19:09
Copy link

Flaky tests detected in 34a0102.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

馃攳 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7588075542
馃摑 Reported issues:

@fabiankaegy fabiankaegy merged commit 2d7be84 into trunk Jan 19, 2024
61 checks passed
@fabiankaegy fabiankaegy deleted the docs/remove-emoji-from-beh branch January 19, 2024 19:36
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants