Font Library: add a setting to customize the conditional download of font assets from a font collection #58030
+4,253
−1,755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arent (#57867) Co-authored-by: Sarah Norris <1645628+mikachan@users.noreply.github.com>
…ised API (#57844) * Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Jason Crist <jcrist@pbking.com>
* Add batchInstallFontFaces function and related plumbing. * Fix resolver name. * Add embedding and rebuild theme.json settings for fontFamily. * Handle responses directly, add to collection before activating. Remove unused test. * Remove getIntersectingFontFaces. * Check for existing font family before installing. * Reference src, not uploadedFile key. Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> * Check for existing font family using GET /font-families?slug=. * Filter already installed font faces (determined by matching fontWeight AND fontStyle) * moved response processing into the resolver for fetchGetFontFamilyBySlug * Moved response processing for font family installation to the resolver * Refactored font face installation process to handle errors more cleanly * Cleanup error handling for font library view * Add i18n function to error messages * Add TODO comment for uninstall notice --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
* Fix delete endpoint * Update fetchUninstallFontFamily to match new format * Update uninstallFont * Add uninstall notice back in * Tidy up comments * Re-word uninstall notices * Add spacing to error message * Refactored how font family values were processed so they would retain their id, which is now used to delete a font family without fetching data via slug * Rename uninstallFont to uninstallFontFamily * Throw uninstall errors rather than returning them --------- Co-authored-by: Jason Crist <jcrist@pbking.com>
…odal/local-fonts.js Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
* Wrap error messages in sprintf * Use await rather than then * Add variables for API URLs * Update packages/edit-site/src/components/global-styles/font-library-modal/resolvers.js Co-authored-by: Jeff Ong <jonger4@gmail.com> --------- Co-authored-by: Jeff Ong <jonger4@gmail.com>
* google fonts collection data provisional url * rename controller methods * fix get_items parameters * fix endpoint return * rafactor font collection class * fix tests for the refactored class * refactor font collections rest controller * update font collection tests * update the frontend to use the new endpoint data schema * format php * adding linter line ignore rul * replacing throwing an exception by calling doing_it_wrong * add translation marks Co-authored-by: Jeff Ong <jonger4@gmail.com> * user ternary operator * correct translation formatting and comments * renaming function * renaming tests * improve url matching Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com> * return error without rest_ensure_response * fix contradictory if condition --------- Co-authored-by: Jeff Ong <jonger4@gmail.com> Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com>
|
Size Change: +49 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
creativecoder
approved these changes
Jan 19, 2024
mikachan
approved these changes
Jan 22, 2024
pbking
reviewed
Jan 22, 2024
| * @property {boolean} richEditingEnabled Whether rich editing is enabled or not | ||
| * @property {boolean} codeEditingEnabled Whether code editing is enabled or not | ||
| * @property {boolean} fontLibraryEnabled Whether the font library is enabled or not. | ||
| * @property {boolean} fontLibraryDownloadAssets Whether the font library is enabled or not. |
There was a problem hiding this comment.
Description should be changed, still have some copy pasta here.
| * @property {boolean} richEditingEnabled Whether rich editing is enabled or not | ||
| * @property {boolean} codeEditingEnabled Whether code editing is enabled or not | ||
| * @property {boolean} fontLibraryEnabled Whether the font library is enabled or not. | ||
| * @property {boolean} fontLibraryDownloadAssets Whether the font library is enabled or not. |
There was a problem hiding this comment.
Suggested change
| * @property {boolean} fontLibraryDownloadAssets Whether the font library is enabled or not. | |
| * @property {boolean} fontLibraryUploadAssets Whether the font library will upload font assets or not. |
creativecoder
force-pushed
the
try/font-library-refactor
branch
from
5d160f2
to
1320d20
Compare
25 tasks
mikachan
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a setting to customize the conditional download of font assets from a font collection.
This is a simpler approach of #57989
Why?
To allow extenders to customize if WordPress Font Library will download the assets when installing font faces from a font collection.
How?
Adds the
fontLibraryDownloadAssetseditor setting that can be customized with PHP using a filter (See testing instructions).It adds
trueas the default value for this setting.Testing Instructions
Check that the font library continues to work as expected. By default, the assets from the font families/faces installed from a font collection featuring external links for the font face assets should be downloaded to the fonts folder (
wp-content/fontsby default). So if you install font families from the Google Fonts collection, you should have the corresponding font assets downloaded in your fonts folder (wp-content/fonts).Use this PHP filter to disable the download of the font assets of the font families installed. With this filter, when installing font faces from a font collection (like the default Google Fonts collection) the font asset won't be downloaded to the fonts folder (
wp-content/fonts), instead of that, the fonts will continue being served from the link provided in the font face definition.