Fix formats not working in block bindings content

[talldan]

What?

Fixes #58053

Currently formats are not working for block bindings content. This PR attempts to resolve the issue.

How?

Currently esc_html is being used on any block content html. This PR switches to using wp_kses_post to allow a subset of safe html.

Testing Instructions

Prerequisite: Enable the pattern overrides experiment from the gutenberg experiment page.

• Create a new post
• Insert a mixture of blocks that include paragraphs and optionally other blocks too
• Select the blocks, and 'Create a pattern' from the block options menu
• Give the pattern a name and make it 'synced'
• Click the 'Edit original' button on the toolbar
• Select a paragraph block in the pattern, and in the block settings sidebar expand the advanced section. Check the 'Allow instance overrides' option
• Use the 'Back' button in the header area of the editor to go back to the post
• Edit the paragraph and add formats
• View the post on the frontend

Screenshots or screencast

Before

After

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/experimental/block-bindings/class-wp-block-bindings.php

[github-actions]

Flaky tests detected in bf62a61a7b90c447ea959ec4dd121dd0afec507c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7606932279
📝 Reported issues:

• [Flaky Test] the event listener is removed when the element is removed #57983 in /test/e2e/specs/interactivity/directive-on-document.spec.ts

[SantosGuillamot]

I've tested it, and it seems to work fine.

cc: @artemiomorales @michalczaplinski In case you have to apply this change in your ongoing PRs.

[michalczaplinski]

cc: @artemiomorales @michalczaplinski In case you have to apply this change in your ongoing PRs.

Thanks, I've applied it in the Core backport 02f0ea3

[getdave]

Backport PR WordPress/wordpress-develop#5888
Trac - https://core.trac.wordpress.org/ticket/60282

[getdave]

✅ I updated this PR with the Backported to Core label to indicate that the backport has successfully merged into WP Core. I also updated the PHP Sync Tracking Issue for WP 6.5.