DataViews: revert list view as default for pages #58081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
mcsf,
ellatrix,
jorgefilipecosta and
ntsekouras
oandregal
added
[Type] Experimental
|
Size Change: -70 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Jan 22, 2024
oandregal
force-pushed
the
update/revert-list-view-as-default-for-pages
branch
from
ba72ab8
to
a4e188b
Compare
|
|
|
Flaky tests detected in 190e8e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7623685372
|
ntsekouras
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
I think we just need to add backPath="/page" here and this looks good to go. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #58079
What?
This reverts using the list view as default when the "new admin views" experiment is active for the Pages page. The dataviews-powered page for Pages can be accessed via "Pages > Manage all pages", when the experiment is active.
Why?
After running the current state with designers & Matías, there are some flows issues that need to be ironed out before making this stable. The list layout won't make it to 6.5, hence it is best to de-emphasize it and give it some time for it to mature.
How
Testing Instructions
With the "admin views" experiment disabled:
Gravacao.do.ecra.2024-01-23.as.10.33.34.mov
With the "admin views" experiment enabled:
Gravacao.do.ecra.2024-01-23.as.10.34.49.mov