New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Show template sources on templates Dataviews sidebar. #58124
Update: Show template sources on templates Dataviews sidebar. #58124
Conversation
Size Change: +800 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
08c4b03
to
b3ff119
Compare
b3ff119
to
106049f
Compare
This is now working for templates & parts: Gravacao.do.ecra.2024-01-23.as.16.25.04.mov |
There's one thing missing: when clicking one of the sidebar items, the
|
Thank you a lot for the review and enhancements @oandregal 😊 |
Thanks for working on this @jorgefilipecosta, it certainly gets us a step closer to closing #58111. There are a couple of details missing:
What do you think? |
} = useLocation(); | ||
|
||
const iconToUse = | ||
icon || VIEW_LAYOUTS.find( ( v ) => v.type === type ).icon; | ||
|
||
const linkInfo = useLink( { | ||
path, | ||
layout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change? In pages list it certainly creates problems(at least in pages list) when changing views. For example if we change a view from the sidebar which has a grid
view set, I'd expect this to be respected without taking into account the current layout
param set.
In general the logic is hard to follow with side effects, when handling the views in sidebar and it would be great if we can simplify and also have more consistency between the different lists(pages, templates).
This PR adds a set of Dynamically generated views to templates dataviews that allows the user to filter the templates by source from the sidebar.
Screenshot