Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Renaming - move backported WP 6.5 code to 6.5 compat dir #58126

Merged
merged 1 commit into from Jan 23, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 23, 2024

What?

Moves shim registering block metadata support to 6.5 compat dir.

Resolves https://github.com/WordPress/gutenberg/pull/54426/files#r1457353078

Why?

Support for metadata was backported to Core in https://core.trac.wordpress.org/ticket/59797. As a result we should now move the code to the compat dir so we know it can safely be removed in future.

How?

Move code.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 23, 2024
@getdave getdave self-assigned this Jan 23, 2024
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/blocks.php
❔ lib/compat/wordpress-6.5/blocks.php

@getdave
Copy link
Contributor Author

getdave commented Jan 23, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

✅ This PR does not require a backport for WP 6.5.

Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@getdave getdave merged commit 44237ca into trunk Jan 23, 2024
60 checks passed
@getdave getdave deleted the update/block-renaming-to-wp-6-5-compat branch January 23, 2024 15:01
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 23, 2024
@getdave
Copy link
Contributor Author

getdave commented Jan 26, 2024

This does not require a backport for 6.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants