Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactivity API: Fix flaky test on-window #58134

Merged
merged 1 commit into from Jan 23, 2024
Merged

Interactivity API: Fix flaky test on-window #58134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/e2e-tests/plugins/interactive-blocks/directive-on-window/render.php
View file
Open in desktop
Expand Up @@ -8,10 +8,18 @@
gutenberg_enqueue_module( 'directive-on-window-view' );
?>

<div data-wp-interactive='{ "namespace": "directive-on-window" }' data-wp-context='{"isVisible":true}'>
<button data-wp-on--click="actions.visibilityHandler" data-testid="visibility">Switch visibility</button>
<div data-wp-show-mock="context.isVisible">
<div data-wp-on-window--resize="callbacks.resizeHandler">
<div data-wp-interactive='{ "namespace": "directive-on-window" }'>
<button
data-wp-on--click="actions.visibilityHandler"
data-testid="visibility">
Switch visibility
</button>
<div data-wp-text="state.isEventAttached" data-testid="isEventAttached">no</div>
<div data-wp-show-mock="state.isVisible">
<div
data-wp-on-window--resize="callbacks.resizeHandler"
data-wp-init="callbacks.init"
>
<p data-wp-text="state.counter" data-testid="counter">0</p>
</div>
</div>
Expand Down
13 changes: 9 additions & 4 deletions packages/e2e-tests/plugins/interactive-blocks/directive-on-window/view.js
View file
Open in desktop
@@ -1,7 +1,7 @@
/**
* WordPress dependencies
*/
import { store, directive, getContext } from '@wordpress/interactivity';
import { store, directive } from '@wordpress/interactivity';

// Mock `data-wp-show` directive to test when things are removed from the
// DOM. Replace with `data-wp-show` when it's ready.
Expand All @@ -19,16 +19,21 @@ directive(
const { state } = store( 'directive-on-window', {
state: {
counter: 0,
isVisible: true,
isEventAttached: 'no',
},
callbacks: {
resizeHandler: ( ) => {
resizeHandler() {
state.counter += 1;
},
init() {
state.isEventAttached = 'yes';
}
},
actions: {
visibilityHandler: () => {
const context = getContext();
context.isVisible = ! context.isVisible;
state.isEventAttached = 'no';
state.isVisible = ! state.isVisible;
},
}
} );