Add: Selection and bulk actions to grid view. #58144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Enhancement
|
Size Change: +332 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
@jorgefilipecosta I've pushed some style adjustments. I think we probably need to include a checkbox otherwise it's not possible to perform a partial selection using the keyboard. I don't have a strong opinion about whether it appears next to the title (first row in screenshot below), or overlays the preview on hover (second row). It's probably one of those details that needs to be felt out. If you can add the checkbox I'm happy to work on those options. 
|
|
Flaky tests detected in 130ff21. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7725189620
|
|
Just quickly tested this and if the are clickable fields(like the title and preview), the Regarding the designs for the checkbox, I'd go with the one before the |
jorgefilipecosta
force-pushed
the
add/selection-and-bulk-actions-to-grid-view
branch
from
50db3d2
to
63cf98b
Compare
|
Hi @ntsekouras, @jameskoster, I updated the PR, it now includes a checkbox to select, and addressed the bug of clickable fields nested inside the grid item executing their action like navigating. |
jorgefilipecosta
force-pushed
the
add/selection-and-bulk-actions-to-grid-view
branch
from
3d0da49
to
ffc183e
Compare
jameskoster
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Thanks @jorgefilipecosta.
I pushed some styles for selected items.
For me the checkbox appearance is a bit prominent and would benefit from a reduction in size, but that's a detail to look at separately.
In terms of design the last piece missing is a click-to-select behavior on the card. I don't think we need that in this PR though so I'm happy to approve :)
jameskoster
approved these changes
Jan 31, 2024
jorgefilipecosta
deleted the
add/selection-and-bulk-actions-to-grid-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to perform bulk actions and make selections using the grid view.
Currently, the only way to select items is by clicking them while holding down the command or ctrl key, or by using the bulk edit select all option. I plan to add support for other standard selection methods, such as using shift-click to select a range of items. Additionally, I will explore the possibility of adding a checkbox to the grid view. I am unsure if it should be visible by default or only appear when hovering over an item.
Screenshots