New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor command tweaks #58148
Minor command tweaks #58148
Conversation
label: | ||
editorMode === 'visual' | ||
? __( 'Open code editor' ) | ||
: __( 'Exit code editor' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use "close" in other commands, but the existing control for the code editor is "Exit" — so we're using that here to maintain that consistency.
Size Change: +383 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Rich! The change looks good to me.
I don't quite understand what the rules are for including undo action in a notice but I trust your judgment here.
If a big change occurs via a control that is not immediately visible. For example, if you enable distraction free, the control for disabling it is hidden (naturally). So I'd want a quick way to help users get back to what they had. The same for fullscreen. |
Minor tweaks to improving feedback when firing commands from the command palette: