DataViews: make the "Manage Pages" stable #58166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ntsekouras,
jorgefilipecosta,
youknowriad,
mcsf,
jameskoster,
SaxonF,
jasmussen and
ellatrix
oandregal
added
[Type] Experimental
|
Size Change: -37 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Here's a quick GIF showing navigating the major sections of the site editor: Pages and Templates are back in the dark material on the left, but the new data views are shown for "manage all templates" and "manage all pages". I think those sections showcase the challenges still — notably that if you edit a page from there, and press the W logo to go back, you're at the detail page, instead of the "manage all" page from whence you came. That was the same problem with the data views enabled for the major sections. I personally think it's okay to ship this as in this PR, as it affords us to hopefully make progress on exactly those flow elements, while shipping a meaningful management screen. But I'm happy to hear from others as well. |
|
Flaky tests detected in 952facd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7637453976
|
I ran this by some people, and it seems the consensus is that we go with this for 6.5. Templates & Parts also work this way, and I agree we need to clarify the flows for everything further. In the interest of making today's RC, I'm going to merge this PR. We're always on time to revert/tweak if it becomes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Makes the "Pages > Manage all pages" stable, with the
tableandgridlayouts available. Before, it redirected to the wp-admin.Why?
It follows what we do for Templates & Parts.
How?
tableandgridlayouts available. But keeplistlayout experimental.Testing Instructions
With the "admin views" experiment disabled:
tableandgridlayouts available, and it only shows the default views in the sidebarGravacao.do.ecra.2024-01-24.as.09.20.44.mov
With the "admin views" experiment enabled:
Gravacao.do.ecra.2024-01-24.as.09.28.03.mov