Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Bindings: Fix button popover not showing in patterns #58219

Merged
merged 2 commits into from Jan 24, 2024
Merged

Block Bindings: Fix button popover not showing in patterns #58219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e3ba71
Use `lockUrlControls` variable in button
SantosGuillamot Jan 24, 2024
222bd27
Add `linkTarget` to JS allowed blocks object
SantosGuillamot Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/use-bindings-attributes.js
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ const BLOCK_BINDINGS_ALLOWED_BLOCKS = {
'core/paragraph': [ 'content' ],
'core/heading': [ 'content' ],
'core/image': [ 'url', 'title', 'alt' ],
'core/button': [ 'url', 'text' ],
'core/button': [ 'url', 'text', 'linkTarget' ],
};

const createEditFunctionWithBindingsAttribute = () =>
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/button/edit.js
View file
Open in desktop
Expand Up @@ -336,7 +336,7 @@ function ButtonEdit( props ) {
{ isLinkTag &&
isSelected &&
( isEditingURL || isURLSet ) &&
! metadata?.bindings?.url && (
! lockUrlControls && (
<Popover
placement="bottom"
onClose={ () => {
Expand Down