Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern block copy in light of pattern overrides #58231

Merged
merged 2 commits into from Jan 30, 2024

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jan 25, 2024

What?

In light of pattern overrides (#53705), the description of the pattern block ("Create and save content to reuse across your site. Update the pattern, and the changes apply everywhere it’s used.") is no longer accurate. (props to @fabiankaegy for spotting the issue)

In particular "the changes apply everywhere it’s used" should be rethought, as changes to pattern overrides are not synced, they're local.

The existing copy also emphasizes using patterns for 'content', which goes against the idea of overrides being used for content and the pattern being more of a design.

How?

Simplifies the copy to "Designs that can be reused across your site.".

Fully aware that I'm a developer, so this is open to suggestions on the copy, but this should be something that's merged sooner so that the text is available for internationalization in WordPress 6.5

Potentially we should also look at removing the description from the block card, as I don't think it makes a lot of sense next to the pattern name (see the screenshot)

Testing Instructions

  1. Add a synced pattern in a post
  2. The block description in the inspector should show the updated copy

Screenshots or screencast

Screenshot 2024-01-25 at 12 35 22 pm

@talldan talldan self-assigned this Jan 25, 2024
@talldan talldan added Needs Copy Review Needs review of user-facing copy (language, phrasing) [Block] Pattern Affects the Patterns Block [Type] Enhancement A suggestion for improvement. labels Jan 25, 2024
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kristastevens
Copy link

Thanks for the copy review ping! I reviewed a bunch of current block descriptions to get a better sense of the language we use to educate users on the purpose of the block. Here's an alternate wording to make the copy active so that it matches the syntax of other block descriptions.

Current suggested wording:
Designs that can be reused across your site.

Proposed wording:
Reuse this design across your site.

@talldan
Copy link
Contributor Author

talldan commented Jan 30, 2024

@kristastevens I much prefer your suggestion, thank you for your help! I think it'll work better in the context of the UI too.

@talldan talldan enabled auto-merge (squash) January 30, 2024 09:15
@talldan talldan merged commit 69f00ae into trunk Jan 30, 2024
55 checks passed
@talldan talldan deleted the update/pattern-block-description-copy branch January 30, 2024 09:45
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 30, 2024
@talldan talldan removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pattern Affects the Patterns Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants