[RNMobile] Disables saving react root view from parent #58266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
[Type] Bug
2 tasks
12 tasks
antonis
changed the title
geriux
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
LGTM! I was able to reproduce the crash following these steps and then confirmed it stopped crashing with these changes 🎉
I didn't see any undesired side-effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
WordPress-Android PR: wordpress-mobile/WordPress-Android#20046
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#6575
What?
The introduced change prevents the EditPostActivity.onSaveInstanceState method of the Android app from saving the React Native view hierarchy.
Why?
This PR attempts to resolve the
TransactionTooLargeExceptionAndroid crash occurring due to the large view data on large post (see wordpress-mobile/WordPress-Android#9685).How?
The change applied prevents the EditPostActivity.onSaveInstanceState method from saving the view hierarchy below ReactRootView resulting in a consistently small
Bundleregardless of the post size.For comparison this is the Bundle of a post before and with the fix applied on this PR
Testing Instructions
See wordpress-mobile/WordPress-Android#20046