Patterns: Change text on pattern reset button #58286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
@SaxonF another suggestion was to move this to the overflow menu, what do you think about this? |
|
Size Change: -4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
49 tasks
kevin940726
approved these changes
Jan 26, 2024
| @@ -408,7 +408,7 @@ export default function ReusableBlockEdit( { | |||
| disabled={ ! overrides } | |||
| __experimentalIsFocusable | |||
| > | |||
| { __( 'Reset to original' ) } | |||
| { __( 'Reset' ) } | |||
There was a problem hiding this comment.
We might need additional context for translators? 🤔
There was a problem hiding this comment.
There are a lot of existing uses of Reset with no translator context, and this use does not seem be different to the existing ones, ie. they all relate to buttons or menu options that are resetting block content, etc. What context are you thinking might be needed in this case?
There was a problem hiding this comment.
I was just being too cautious for some languages that might need additional context but I can't think of any off the top of my head 😅. Let's keep it this way until we need it 😄.
glendaviesnz
added
the
Backport to Gutenberg RC
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 13ef08d |
cbravobernal
removed
the
Backport to Gutenberg RC
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the text of the
Reset to originalbutton to justResetWhy?
Feedback suggested this was better.
How?
Updated the button text.
Testing Instructions
Resetand works as expected.Screenshots or screencast
Before:
After: