E2E Utils: Wait for canvas instead of window.wp #58318
Draft
+8
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In testing against a slower env (wp.com in my case) it turned out that the
window.wp.*
is ready before the canvas is, so calling utils likeinsertBlock
immediately after creating a post has no effect. Waiting for the canvas instead gives stable results and makes the affected utils work as expected.Why?
For stability.
Testing Instructions
Nothing particular. All the tests should pass.