E2E Utils: Ensure deleteAllUsers does not delete current user

[WunderBart]

What?

When calling deleteAllUsers, let's ensure we don't attempt to delete the current user, which can be a non-admin user.

Testing Instructions

Create a non-admin account and provide the credentials (export WP_USERNAME and WP_PASSWORD). Run e.g. the autocomplete-and-mentions.spec.js suite and ensure it doesn't attempt to delete the current user in the afterAll hook.

[Mamaduka]

What do you mean by non-admin user? A user with different username that default one for tests?

Should we just check against username which should be unique? Because ID = 1 isn’t always guaranteed.

[WunderBart]

What do you mean by non-admin user? A user with different username that default one for tests?

Yep! Basically a user that is currently logged in and is not Admin (the default account).

Should we just check against username which should be unique? Because ID = 1 isn’t always guaranteed.

Oh, I haven't changed that bit. I thought the default root account has always id == 1, no? We can change that to compare against "Admin" username instead if that's more solid!

[Mamaduka]

I thought the default root account has always id == 1, no?

Auto incremented IDs are never guaranteed IMO. But logic has been working so far so no need to change it yet 😄

[Mamaduka]

Sorry forgot to approve.

[WunderBart]

Ugh, I just noticed that it should be OR not AND. It should filter out either the id=1 or the current user by username. Will fix that shortly.

edit: Lol nope, it's all good actually! 😅