Block Hooks API: Remove $post check from Navigation hooked blocks meta fn

[tjcafferkey]

What?

Remove the check on $post->ID and silent return in block_core_navigation_update_ignore_hooked_blocks_meta since Core guarantees its existence.

Why?

This part of the code was picked up during the package updates for 6.5 here. Core pretty much guarantees this data will be available within the callback as seen here and here.

How?

This removes the code which executes a silent return on an unnecessary check.

Testing Instructions

If required, regression testing steps on this feature can be found on this PR #57754

[ockham]

LGTM! Thank you for the fix.

[ockham]

Core pretty much guarantees this data will be available within the callback as seen here and here.

As discussed on Slack, this is what convinced me that we should be fine removing the extra check from the filter.

Core even goes out of its way to find out and specify what the error is. Only after that does it call get_post; i.e. it’s assuming that errors have been handled, and as a consequence, we wouldn’t even have any information what it was. (So we could only throw a very generic error anyway.)

[cbravobernal]

I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: f217c68