Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: remove font family and font face preview keys from theme.json schema #58395

Merged
merged 1 commit into from Jan 29, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Font Library: remove font family and font face preview keys from theme.json schema

Why?

See: #58392

How?

Removing the not longer needed key just added during the implementation process of the Font Library.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/class-wp-theme-json-gutenberg.php

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that this successfully reverts the changes made in #56793. LGTM!

@matiasbenedetto matiasbenedetto merged commit 516fab0 into trunk Jan 29, 2024
58 of 65 checks passed
@matiasbenedetto matiasbenedetto deleted the revert/add-preview-to-theme-json-schema branch January 29, 2024 20:46
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font Library: remove font family and font face preview keys from theme.json schema
2 participants