New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Hooks API: Update new Navigation functions with @since annotation #58437
base: trunk
Are you sure you want to change the base?
Block Hooks API: Update new Navigation functions with @since annotation #58437
Conversation
Flaky tests detected in dc365aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7710802008
|
TBH I'm not 100% sure what's our policy with regard to It actually gives me pause that none of the functions in the file currently have a |
Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
I don't see any https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/categories/index.php |
@getdave yeah, I checked and noticed this myself but it was explicitly called out as part of this PR, see here https://github.com/WordPress/wordpress-develop/pull/5922/files#r1469818024 I'm unfamiliar with whether it's required/needed or not. If we think not, then we can close the PR. |
I did notice a couple of instances in WP Core. I think perhaps we need to start documenting changes using @youknowriad do you have a view on this? Is there any precedent or prior discussion that I might not be aware of? |
I think I agree with this. It's true that we probably didn't follow this consistently so far. |
What?
Update new functions created for Block Hooks API to work with the Navigation block with
@since 6.5.0
annotations.