Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Nav Link PHPUnit tests to blocks directory #58460

Merged
merged 1 commit into from Jan 31, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 30, 2024

What?

Moves Nav Link block tests to blocks/ dir of phpunit/ dir.

Why?

Tests relating to specific blocks shoulld be within the /blocks dir of the phpunit dir.

How?

git mv

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 30, 2024
@getdave getdave self-assigned this Jan 30, 2024
@getdave getdave marked this pull request as ready for review January 30, 2024 16:11
Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ phpunit/blocks/class-block-library-navigation-link-test.php

@getdave
Copy link
Contributor Author

getdave commented Jan 30, 2024

@draganescu When reviewing #58068 I noticed tests were in the wrong dir. This PR resolves that.

Copy link

Flaky tests detected in e7e0390.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7714078703
📝 Reported issues:

@getdave
Copy link
Contributor Author

getdave commented Jan 31, 2024

This will not require a backport as the unit tests are for blocks only.

Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@getdave getdave force-pushed the update/move-nav-link-block-tests-to-blocks-dir branch from e7e0390 to 26dc91e Compare January 31, 2024 13:36
@getdave getdave enabled auto-merge (squash) January 31, 2024 13:37
@getdave getdave merged commit 30b3000 into trunk Jan 31, 2024
55 checks passed
@getdave getdave deleted the update/move-nav-link-block-tests-to-blocks-dir branch January 31, 2024 14:07
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants