Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Remove slug from collection schema to accommodate the changes on the wp_register_font_collection function signature #58623

Merged
merged 1 commit into from Feb 2, 2024

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Feb 2, 2024

What?

Font Library: Remove slug from collection schema to accommodate the changes on the wp_register_font_collection function signature done in #58530

Why?

The slug is no longer part of the required collection JSON data. The slug is added in PHP when a font collection is registered. Example

wp_register_font_collection( 'my-collection-slug', 'https://example.com/fonts/my-collection.json' );

How?

Removing the slug from the schema

…wp_register_font_collection function signature
Copy link

github-actions bot commented Feb 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: mmaattiiaass, pbking.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: pbking <pbking@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto matiasbenedetto enabled auto-merge (squash) February 2, 2024 16:08
@matiasbenedetto matiasbenedetto merged commit d801d77 into trunk Feb 2, 2024
63 of 64 checks passed
@matiasbenedetto matiasbenedetto deleted the remove/slug-from-collection-schema branch February 2, 2024 16:29
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants