Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library Address Outstanding Feedback from WP 6.4 review #58675

Merged
merged 8 commits into from Feb 5, 2024
Merged

Font Library Address Outstanding Feedback from WP 6.4 review #58675

merged 8 commits into from Feb 5, 2024

Commits on Feb 5, 2024

  1. Translate error string 

    Addresses https://github.com/WordPress/wordpress-develop/pull/5285/files#r1345355956
    @getdave
    getdave committed Feb 5, 2024
    Copy the full SHA
    20cbc75 View commit details
    Browse the repository at this point in the history

  2. Improve get_allowed_font_mime_types comment

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    4f846fa View commit details
    Browse the repository at this point in the history

  3. Use str_contains rather than strpos

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    82c04d5 View commit details
    Browse the repository at this point in the history

  4. Move period outside double quotes

    @getdave
    getdave committed Feb 5, 2024
    Copy the full SHA
    e187b03 View commit details
    Browse the repository at this point in the history

  5. Correct error message

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    ab62473 View commit details
    Browse the repository at this point in the history

  6. Use sprintf for parameter names in translated strings

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    f6f513f View commit details
    Browse the repository at this point in the history

  7. Capitalize HTTP

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    59e6fde View commit details
    Browse the repository at this point in the history

  8. Updates tests

    @creativecoder
    creativecoder committed Feb 5, 2024
    Copy the full SHA
    28bbc36 View commit details
    Browse the repository at this point in the history