Apply 40px across summary panel. #58730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +34 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The rows are now 40px, but the buttons inside are still 36px, is that intentional? 
|
|
Good question. I'd actually love to hear from @mirka on best practices here; the buttons should definitely be 40px, but do we simply apply |
It will eventually solve itself when we actually switch over the defaults. But I can't really say when that will happen. We're basically waiting for the entire Gutenberg app to get ready for the 40px defaults, which it looks like we're getting pretty close! There are still some places that need to be adapted, for example these controls in the Group block: 
Whenever the design team thinks we're ready, just let me know and we can start switching over all the defaults. Until then, opting in with
You can pass Button props to <DropdownMenu
toggleProps={ {
__next40pxDefaultSize: true,
} } |
|
Thanks for the tip. I can't easily get it to work, feel free to push changes to this branch if need be. Otherwise I think we can move forward, the important part for now is the row height. What do you think? |
|
Any reason not to add |
|
No reason, I just couldn't get the code sample to work, and had to switch gears to work on something else :) Feel free to push if you have it. |
I see, some of the components were a little deeper in the tree. I pushed the changes 👍 54c84e7 |
jameskoster
reviewed
Feb 9, 2024
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .editor-post-panel__row-control { | ||
| flex-grow: 1; | ||
| min-height: $button-size; | ||
| min-height: $button-size-next-default-40px; |
There was a problem hiding this comment.
We could potentially remove this. It only seems to exist for cases where the row doesn't include a control/button, which doesn't seem a likely occurrence?
jameskoster
approved these changes
Feb 9, 2024
|
Good feedback. I tried removing those, though then this happens:
|
jasmussen
force-pushed
the
try/summary-panel-polish
branch
from
54c84e7
to
04333b3
Compare
|
Ah I only meant the one applied to
|
MaggieCabrera
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Continues progress on #46734.
Currently there's a mix of previous 36px button sizes, and 40px button sizes in the Summary panel. This is a small PR to apply the new default 40px size across. Before:
After:
The change makes the controls 280px tall, where before they were 252px. So it's 28px taller.