Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: update fonts collection data url for Gutenberg 17.7 #58746

Merged
merged 1 commit into from Feb 6, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Font Library: update fonts collection data url for Gutenberg 17.7

Why?

To use the updated data structure for Gutenberg 17.7 hosted on the wordpress.org CDN.
https://meta.trac.wordpress.org/ticket/7441#ticket

How?

Removing the provisional URL coming from a GitHub repo and using the wordpress.org CDN for this version.

Testing Instructions

  • Open the Google Fonts collection
  • Install some fonts from there.
  • Check that the fonts were installed correctly.

Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props mmaattiiaass, grantmkin.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto matiasbenedetto added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Font Library labels Feb 6, 2024
@matiasbenedetto matiasbenedetto requested review from creativecoder, pbking and youknowriad and removed request for spacedmonkey February 6, 2024 17:57
Copy link

github-actions bot commented Feb 6, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/fonts/fonts.php

Copy link
Contributor

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected for me.

@matiasbenedetto matiasbenedetto merged commit b501797 into trunk Feb 6, 2024
64 of 65 checks passed
@matiasbenedetto matiasbenedetto deleted the update/google-fonts-collection-url branch February 6, 2024 19:06
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 6, 2024
@creativecoder
Copy link
Contributor

One thing that comes to mind while reviewing this is that we should account for when Core also registers the google-fonts collection, to not and try to register it twice.

@creativecoder
Copy link
Contributor

we should account for when Core also registers the google-fonts collection, to not and try to register it twice.

Handled here: #58769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants