Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Bindings: lock editing of blocks by default #58787

Merged
merged 6 commits into from Feb 12, 2024
Merged

Block Bindings: lock editing of blocks by default #58787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13839fd
Lock editing by default when bindings exist
SantosGuillamot Feb 9, 2024
dc9da5c
Use default in post meta source
SantosGuillamot Feb 9, 2024
fd32d62
Set `lockEditing` to false in pattern overrides
SantosGuillamot Feb 9, 2024
79a42c5
Move default value to reducer
SantosGuillamot Feb 9, 2024
228c142
Use `_x` for sources translations
SantosGuillamot Feb 9, 2024
653a477
Add context to translations
SantosGuillamot Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/editor/src/bindings/pattern-overrides.js
View file
Open in desktop
@@ -1,11 +1,11 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { _x } from '@wordpress/i18n';

export default {
name: 'core/pattern-overrides',
label: __( 'Pattern Overrides' ),
label: _x( 'Pattern Overrides' ),
useSource: null,
lockAttributesEditing: false,
};
4 changes: 2 additions & 2 deletions packages/editor/src/bindings/post-meta.js
View file
Open in desktop
Expand Up @@ -3,15 +3,15 @@
*/
import { useEntityProp } from '@wordpress/core-data';
import { useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import { _x } from '@wordpress/i18n';
/**
* Internal dependencies
*/
import { store as editorStore } from '../store';

export default {
name: 'core/post-meta',
label: __( 'Post Meta' ),
label: _x( 'Post Meta' ),
Copy link
Member

@gziolo gziolo Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mirror: https://github.com/WordPress/wordpress-develop/blob/acad00ecabcf44a6c4e552c4fd518ee708fd131f/src/wp-includes/block-bindings/post-meta.php#L52

_x( 'Post Meta', 'block bindings source' ),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Done in this commit.

useSource( props, sourceAttributes ) {
const { getCurrentPostType } = useSelect( editorStore );
const { context } = props;
Expand Down