Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guidelines around Component versioning #58789

Merged
merged 2 commits into from Feb 13, 2024

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Feb 7, 2024

Related to #58324

What?

This PR introduces a section in the Contributing Guidelines of the @wordpress/components package to standardize the procedure of introducing a new version of an existing component.

Why?

We've been recently working on introducing new version of existing components (Tooltip, TabPanel, CustomSelectControl, DropdownMenu, Composite). While working on it, we gathered experience on what worked well, and we thing it's a good idea to standardize the process for future work.

Copy link

github-actions bot commented Feb 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo ciampo added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Feb 7, 2024
@ciampo ciampo requested a review from mirka February 7, 2024 18:22
Copy link

github-actions bot commented Feb 7, 2024

Flaky tests detected in 0f84f5c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7848307301
📝 Reported issues:

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

@mirka mirka merged commit 8c58423 into trunk Feb 13, 2024
57 of 58 checks passed
@mirka mirka deleted the docs/components-versioning branch February 13, 2024 10:04
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 13, 2024
@mirka mirka mentioned this pull request Feb 19, 2024
1 task
@bph bph changed the title Add contributing guidlines around Component versioning Add contributing guidelines around Component versioning Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants