Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style theme variations: add property extraction and merge utils #58803

Merged
merged 10 commits into from Feb 13, 2024
Merged

Style theme variations: add property extraction and merge utils #58803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d0a9d12
First commit
ramonjd Feb 8, 2024
73c62b9
Adding failing tests :)
ramonjd Feb 8, 2024
e97054a
Adds working tests
ramonjd Feb 13, 2024
28b1564
Adds more tests
ramonjd Feb 13, 2024
d80fa65
Adds filterObjectByProperty tests
ramonjd Feb 13, 2024
5fbca49
Update packages/edit-site/src/hooks/use-theme-style-variations/use-th…
ramonjd Feb 13, 2024
ee36d45
Merge map callbacks
ramonjd Feb 13, 2024
1ef39b8
More tests, adding a `null` check too
ramonjd Feb 13, 2024
3fa7504
Update comment to reflect functionality
ramonjd Feb 13, 2024
43c2cd3
Update test to ensure we don't reference original object
ramonjd Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/edit-site/src/hooks/push-changes-to-global-styles/index.js
View file
Open in desktop
Expand Up @@ -26,6 +26,7 @@ import { store as coreStore } from '@wordpress/core-data';
*/
import { useSupportedStyles } from '../../components/global-styles/hooks';
import { unlock } from '../../lock-unlock';
import cloneDeep from '../../utils/clone-deep';
ramonjd marked this conversation as resolved.
Show resolved Hide resolved

const { cleanEmptyObject, GlobalStylesContext } = unlock(
blockEditorPrivateApis
Expand Down Expand Up @@ -275,10 +276,6 @@ function setNestedValue( object, path, value ) {
return object;
}

function cloneDeep( object ) {
return ! object ? {} : JSON.parse( JSON.stringify( object ) );
}

function PushChangesToGlobalStylesControl( {
name,
attributes,
Expand Down