Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript #58818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
gziolo,
sirreal,
luisherranz,
ellatrix and
DAreRodz
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/class-wp-script-modules.php ❔ lib/compat/wordpress-6.5/script-loader.php |
youknowriad
reviewed
Feb 8, 2024
| @@ -107,3 +107,109 @@ static function ( $settings ) { | |||
| return $settings; | |||
| } | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
Should this be in the 6.5 folder though? This fix is not on 6.4 right?
There was a problem hiding this comment.
That's true. I mislead with being compatible with 6.4 versions.
youknowriad
approved these changes
Feb 8, 2024
cbravobernal
force-pushed
the
fix/import-map-loading-not-html5-templates
branch
2 times, most recently
from
9dc0bdd
to
467c624
Compare
cbravobernal
force-pushed
the
fix/import-map-loading-not-html5-templates
branch
from
467c624
to
c4b48b6
Compare
cbravobernal
added a commit
that referenced
this pull request
Feb 8, 2024
…pt (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
cbravobernal
added a commit
that referenced
this pull request
Feb 8, 2024
…pt (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
cbravobernal
added a commit
that referenced
this pull request
Feb 8, 2024
…pt (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
cbravobernal
removed
the
Backport to Gutenberg Minor Release
cbravobernal
added a commit
that referenced
this pull request
Feb 8, 2024
* Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> * Revert "Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818)" This reverts commit 2a16bdd. * Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> * Revert "Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818)" This reverts commit 4b65571. * Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818) * Add fix from Core Trunk to Gutenberg * Move to 6.5 compat folder Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> * Load scrip-loader file, was not in the cherry-pick * Revert "Import Maps: Only emit CDATA wrappers for inline scripts for JavaScript (#58818)" This reverts commit 2031222. * Revert "Load scrip-loader file, was not in the cherry-pick" This reverts commit 94237e0. * Fix cdata crashing modules in not html5 compatible themes --------- Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I'm backporting this fix for WordPress 6.4. So that sites with WP < 6.5 and Gutenberg, and old classic themes that does not support html5.
WordPress/wordpress-develop#5925
Testing Instructions
trunk, it should work in this PR.