Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Move Core implementation to compat 6.5 folder #58829

Merged
merged 3 commits into from Feb 8, 2024

Conversation

DAreRodz
Copy link
Contributor

@DAreRodz DAreRodz commented Feb 8, 2024

What?

Updates all the Interactivity API PHP files implementation in Gutenberg using the current one in WordPress core (implemented in WordPress/wordpress-develop#5953).

All the related PHPUnit files are not needed anymore in Gutenberg, as there are tests in WordPress core for all features.

@DAreRodz DAreRodz added [Type] Build Tooling Issues or PRs related to build tooling Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props darerodz, youknowriad, cbravobernal, luisherranz, get_dave.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 8, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api-directives-processor.php
❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php
❔ lib/compat/wordpress-6.5/interactivity-api/interactivity-api.php
❔ lib/experimental/interactivity-api.php

@@ -14,7 +14,7 @@
function gutenberg_interactivity_override_script_module_urls( $url ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file still in experimental? Is it something that will remain in Gutenberg forever? Should it move to compat folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will remove that file and move to the external folder:
#58830

@DAreRodz DAreRodz enabled auto-merge (squash) February 8, 2024 11:59
@youknowriad
Copy link
Contributor

Looks like there's still some e2e test failures.

@luisherranz
Copy link
Member

They don't look related to the Interactivity API.

@getdave
Copy link
Contributor

getdave commented Feb 8, 2024

e2e test failures do indeed look like problems with Synced Pattern work which seems unrelated. Can we force merge this PR to unblock the PHP unit tests?

@getdave
Copy link
Contributor

getdave commented Feb 8, 2024

Actually I noticed the e2e tests seem to fail on REST API errors. Is there some conflict here causing REST to fail?

@youknowriad youknowriad merged commit bcbaecf into trunk Feb 8, 2024
67 of 70 checks passed
@youknowriad youknowriad deleted the update/interactivity-api-compat-files branch February 8, 2024 15:20
@youknowriad
Copy link
Contributor

Ok, so I forced merged this to fix the php unit test but let's continue on the e2e tests, they seem block bindings related.

@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants