DataViews: fix storybook #58842
Merged
DataViews: fix storybook #58842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
fix/dataviews-storybook
branch
from
14480d6
to
e68fc2a
Compare
oandregal
force-pushed
the
fix/dataviews-storybook
branch
from
e68fc2a
to
f088e32
Compare
|
Flaky tests detected in f088e32. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7900830498
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Fixes the storybook for dataviews: upon clicking the view actions menu it broke.
How?
Import constants from the proper place.
Testing Instructions
Run storybook locally, and verify that you can interact with the view actions menu. The easiest way to reach it is via keyboard (you can also scroll horizontally).
Gravacao.do.ecra.2024-02-14.as.12.57.38.mov
In
trunk, upon clicking the menu there is an error: