Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Bindings: Update bindings registry with latest changes #58843

Merged

Conversation

SantosGuillamot
Copy link
Contributor

What?

Migrate the changes made in core to Gutenberg plugin.

Why?

To keep the code synced and solve and issue with the e2e tests.

How?

Just copy and pasting 🙂

Copy link

github-actions bot commented Feb 8, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props santosguillamot, czapla.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: michalczaplinski <czapla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 8, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/block-bindings/class-wp-block-bindings-source.php
❔ lib/compat/wordpress-6.5/block-bindings/block-bindings.php
❔ lib/compat/wordpress-6.5/block-bindings/class-wp-block-bindings-registry.php
❔ lib/compat/wordpress-6.5/blocks.php
❔ lib/load.php

@SantosGuillamot SantosGuillamot added [Type] Bug An existing feature does not function as intended [Feature] Custom Fields Anything related to the custom fields project - connecting block attributes and dynamic values labels Feb 8, 2024
@michalczaplinski michalczaplinski force-pushed the fix/update-bindings-registry-with-latest-changes branch from 5a377e1 to 4d02f95 Compare February 8, 2024 15:23
Copy link
Contributor

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Mario 👍

@michalczaplinski michalczaplinski enabled auto-merge (squash) February 8, 2024 15:56
@michalczaplinski michalczaplinski merged commit 7fde6a8 into trunk Feb 8, 2024
57 checks passed
@michalczaplinski michalczaplinski deleted the fix/update-bindings-registry-with-latest-changes branch February 8, 2024 15:58
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Custom Fields Anything related to the custom fields project - connecting block attributes and dynamic values [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants