Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete wp-env configuration from package.json (#58877) #58899

Merged

Conversation

shreyash3087
Copy link
Contributor

What?

This PR removes obsolete wp-env configuration from the package.json file in the monorepo setup.

fixes #58877

Why?

The wp-env configuration in the package.json file is outdated and no longer necessary for the project. This PR aims to clean up the project by removing these obsolete settings, improving maintainability and reducing clutter in the configuration files.

How?

The obsolete wp-env configuration settings, including 'plugin-dir', 'plugin-name', 'docker-template', 'welcome-logo', and 'welcome-build-command', are removed from the package.json file. Additionally, the referenced 'bin/docker-compose.override.yml.template' file is deleted as it is no longer in use.

Testing Instructions

  1. Clone the repository.
  2. Checkout to the branch containing this PR.
  3. Run npm ci to install dependencies.
  4. Run npm run build to build the project.
  5. Finally, run npm run env start to start WordPress including Gutenberg.
  6. Verify that WordPress and Gutenberg work as expected without the removed wp-env configuration.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

Copy link

github-actions bot commented Feb 9, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Feb 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shreyash3087 <shreyash3087@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: lgersman <lgersman@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Feb 10, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@talldan talldan merged commit adbd3a2 into WordPress:trunk Feb 12, 2024
61 of 64 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json already contains stone age old obsolete wp-env configuration
3 participants