Update cherry pick script to add Backported to WP Core label for backports
#58970
Conversation
getdave
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
bin/cherry-pick.mjs
Outdated
| @@ -334,6 +334,11 @@ function reportSummaryNextSteps( successes, failures ) { | |||
| nextSteps.push( 'Push this branch' ); | |||
| nextSteps.push( 'Go to each of the cherry-picked Pull Requests' ); | |||
| nextSteps.push( `Remove the ${ LABEL } label` ); | |||
|
|
|||
| if ( LABEL === 'Backport to WP Beta/RC' ) { | |||
| nextSteps.push( 'Add the "Backported to WP Core" label' ); | |||
There was a problem hiding this comment.
Should this label be hard coded in the code or should we make it an argument like LABEL?
There was a problem hiding this comment.
Or at least a const
There was a problem hiding this comment.
@youknowriad I added a const for now. I don't have a use case for making this another arg yet. If we have one in the future we can easily add this.
It would be useful to bring this change in prior to Beta 3.
getdave
deleted the
update/add-backported-label-when-cherry-picking-to-wp-release
branch
…ckports (#58970) * Update script to add label * Use named const
|
I have cherry picked this PR into the |
What?
Updates the cherry picking script to also add the
Backported to WP Corelabel when cherry picking a PR for a backport during a WP release cycle.Why?
Because we established a new convention whereby this label would be applied. In the future, usage of this label will help us to avoid false positives when building the PHP Sync Issue as it will allow us to omit PR which have this label from the list of commits that need manually syncing to WP Core.
How?
Uses GH Cli to edit the PR and add the label
Testing Instructions
Good question. There are no automated tests...
Testing Instructions for Keyboard
Screenshots or screencast
Co-authored-by: getdave get_dave@git.wordpress.org
Co-authored-by: youknowriad youknowriad@git.wordpress.org