Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Upgrade React version to 16.3.0 #5900

Merged
merged 1 commit into from Mar 30, 2018
Merged

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Mar 30, 2018

Description

This PR updateS React version to version 16.3.0 (it was moved to its own PR from #5029). One of the new features that 16.3.x is going to introduce is new context API. There are no breaking changes in this release.

Note: Enzyme hasn't published a new version yet although they landed in master changes required to make it possible to test new Context Components. We will have to tackle it separately with @wordpress/jest-preset-default upgrade.

Release details:
https://reactjs.org/blog/2018/03/29/react-v-16-3.html

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo added the Framework Issues related to broader framework topics, especially as it relates to javascript label Mar 30, 2018
@gziolo gziolo self-assigned this Mar 30, 2018
@gziolo gziolo requested a review from a team March 30, 2018 09:01
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO IT

@gziolo gziolo added this to the 2.6 milestone Mar 30, 2018
Copy link
Member

@atimmer atimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't let your dreams be dreams

@youknowriad
Copy link
Contributor

Let's merge it to see if anything breaks soon enough.

@youknowriad youknowriad merged commit 898efbe into master Mar 30, 2018
@youknowriad youknowriad deleted the update/react-16.3 branch March 30, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants