Make 'All pages' view label consistent with template and patterns #59009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -9 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
oandregal
approved these changes
Feb 14, 2024
|
I check your changes. all looks good. |
|
Flaky tests detected in 1b245be. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7932980581
|
t-hamano
reviewed
Feb 14, 2024
| @@ -49,7 +49,7 @@ const DEFAULT_PAGE_BASE = { | |||
| export const DEFAULT_VIEWS = { | |||
| page: [ | |||
| { | |||
| title: _x( 'All', 'pages' ), | |||
| title: _x( 'All pages', 'pages' ), | |||
There was a problem hiding this comment.
Suggested change
| title: _x( 'All pages', 'pages' ), | |
| title: __( 'All pages' ), |
Context may no longer be necessary.
Note: If you apply this suggestion, you will also need to remove _x from the import statement to pass the lint check.
There was a problem hiding this comment.
That's true, good suggestion :)
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
…9009) Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 35f7226 |
getdave
removed
the
Backport to WP Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…9009) Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: huzaifaalmesbah <huzaifaalmesbah@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the label on the data view for all pages.
Why?
So that it's consistent with patterns and templates.
References