Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add sleep() before all Tab() to fix flaky tests #59012

Merged
merged 1 commit into from Feb 15, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 14, 2024

What?

This PR adds some additional sleep() calls before all press.Tab() calls to fix the flakiness.

Why?

To reduce the test flakiness. Another press.Tab() test failed right during merging #58968 to trunk so I think we should apply this everywhere and see how it goes.

How?

We're adding some wait time (10ms which is the default of sleep()) before tabbing.

This doesn't really fix the root cause, but we're aiming to fix the flaky tests for now.

We also did this in #58629 and #58968.

Testing Instructions

Verify all tests pass.

Testing Instructions for Keyboard

None

Screenshots or screencast

None

@tyxla tyxla added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Package] Components /packages/components labels Feb 14, 2024
@tyxla tyxla self-assigned this Feb 14, 2024
Copy link

github-actions bot commented Feb 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Flaky tests detected in b84ba73.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7901704414
📝 Reported issues:

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try.

Is there an issue for resolving the root cause of the flakiness? We should probably include reverting "hacks" like these as a follow-up step there.

@tyxla tyxla merged commit decaae6 into trunk Feb 15, 2024
66 checks passed
@tyxla tyxla deleted the fix/flaky-tests-sleep-press-tab branch February 15, 2024 11:53
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 15, 2024
@tyxla
Copy link
Member Author

tyxla commented Feb 15, 2024

Is there an issue for resolving the root cause of the flakiness? We should probably include reverting "hacks" like these as a follow-up step there.

Good idea. I've opened #59071 to keep track of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants