Fix DFM ui toggling bugs #59061
Merged
Fix DFM ui toggling bugs #59061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +37 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9dcdf4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7915591901
|
|
I think this is the way to go, we should keep the flags independent between each other. There's a unit test failure, is that an intermittent failure? |
youknowriad
approved these changes
Feb 15, 2024
scruffian
approved these changes
Feb 15, 2024
|
Hmm, seems I need to update a test with some mocking |
…in site editor if DFM is on, don't render post editor inspector if DFM is on
draganescu
force-pushed
the
fix/dfm-ui-toggle-bugs
branch
from
78fda85
to
9dcdf4d
Compare
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
* don't open post editor inspector if DFM is on, hide list view toggle in site editor if DFM is on, don't render post editor inspector if DFM is on * udpdate tests with the new call for dfm pref and add two tests for when dfm is on Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 81115e7 |
youknowriad
removed
the
Backport to WP Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
* don't open post editor inspector if DFM is on, hide list view toggle in site editor if DFM is on, don't render post editor inspector if DFM is on * udpdate tests with the new call for dfm pref and add two tests for when dfm is on Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org>
creativecoder
added
the
[Feature] Distraction Free
|
Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Feature] Distraction Free to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59028
Why?
To keep the UI distraction free, and to fix the bugs which would prevent sidebars from being closed.
How?
Testing Instructions
Go to site editor
Toggle DFM on
Check the list view toggle does not appear in the header
Go to the site editor
Toggle DFM off
Toggle the block inspector on
Toggle DFM on
Go to post editor
Check the block inspector does not show
Testing Instructions for Keyboard
N/A
Screenshots or screencast
fix-dfm-ui-toggle-bugs.mp4