Fix Navigation link control overlapping issue #59065
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Type] Bug
|
|
||
| .block-editor-link-control__search-item-top { | ||
| .components-button.has-icon { | ||
| min-width: 50px; |
There was a problem hiding this comment.
Do we need a min-width is width is set?
| .components-button.has-icon { | ||
| min-width: 50px; | ||
| width: 50px; | ||
| padding: 0 5px; |
There was a problem hiding this comment.
Rather than adding padding on both sides, what do you think about adding a gap to the parent element? This means we don't add extra padding on the left and right of the buttons which makes a better use of the space IMO
There was a problem hiding this comment.
Thank you for suggestions, I have updated css to make better use of space.
|
|
||
| .components-button.has-icon { | ||
| min-width: inherit; | ||
| width: min-content; |
There was a problem hiding this comment.
This is much better for other languages, thank you
getdave
changed the title
getdave
added
the
Backport to WP Beta/RC
|
This will need to be included in the backports for Beta 3. I added the requisite label. |
* Fix nagivation link control overlapping issue * Addressed feedback * use variable insted fixed number in spacing
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 667797e |
getdave
added
Backported to WP Core
* Fix nagivation link control overlapping issue * Addressed feedback * use variable insted fixed number in spacing
What?
Fixed #59054
Why?
There was overlapping in link control when "Show button text labels" enable from Preferences.
How?
We are hiding URL from "copy link" button lable when "Show button text labels" enabled. So button text doesn't overlap each other.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast